search

Mindera / pm2-cookbook

Chef cookbook to install and manage PM2.
MIT License
23 stars 17 forks source link

Berksfile.lock #4

Closed jarosser06 closed 9 years ago

jarosser06 commented 9 years ago

Is there a particular reason your including the Berksfile.lock in this cookbook? Usually the lock file is not checked in to library cookbooks.

miguelcnf commented 9 years ago

We tend to version the lock files to represent the last good known state in which the cookbook was validated. It also allows sharing a sane development/test environment to work on by locking transactive dependencies with which we had issues in the past with community libraries.

Have you had any issue with it or know of a reason why not to?

jarosser06 commented 9 years ago

The lock file isn't getting updated when the cookbook version gets updated. We generally try to keep the Berks lock files in our wrapper cookbooks because we have had issues with Library cookbooks manipulating berks in the past.

miguelcnf commented 9 years ago

I figure we can live without it and this way avoid getting other people in trouble.

Removed in https://github.com/Mindera/pm2-cookbook/commit/6a59121f5abbbb3555e14510d3cdc7a021261443.