search

Mindinventory / AndroidCircularSlider

Create Highly Customizable Circular Slider made with Jetpack compose
https://www.mindinventory.com/android-application-development.php
MIT License
63 stars 3 forks source link

feat(tap): set position to tapped location #3

Closed conkur closed 1 year ago

conkur commented 1 year ago

Now the slider will move to the tapped location. This adds another way to adjust the slider other than dragging the thumb circle.

Also adds .idea to .gitignore so the whole folder is ignored

conkur commented 1 year ago

Codeowners: I wanted to get your thoughts on this. For my own project, I wanted to add tap capabilities but I'm not sure if it is desired by you. Feel free to close this if this behavior is not desired. Let me know if you'd like a video demonstrating the change.

akashmi commented 1 year ago

@conkur Thanks for using this lib and creating PR with enhancement. will definitely look into this.

conkur commented 1 year ago

@akashmi Thanks! Great library, very clean. If I end up finishing my project which is currently using this library I will share my work

akashmi commented 1 year ago

@conkur we have included your changes along with a few more enhancements in this PR https://github.com/Mindinventory/AndroidCircularSlider/pull/5

and released the new version 0.0.2. thanks for your contribution.