search

Mindinventory / vanilla-place-picker

Simple(vanilla) yet 'Do it all' place picker for your place picking needs in Android
https://www.mindinventory.com/android-application-development.php
MIT License
120 stars 34 forks source link

Show keyboard on search screen #14

Closed Gnzlt closed 5 years ago

Gnzlt commented 5 years ago

I think it's a necessary UX improvement to show the keyboard when entering the Search screen, that way the user will be able to type straightaway without having to tap on the top bar.

malikmotani commented 5 years ago

@Gnzlt I think only android:windowSoftInputMode="stateAlwaysVisible" will work

Gnzlt commented 5 years ago

You need both, I already tried 😅

malikmotani commented 5 years ago

I tried with android:windowSoftInputMode="stateAlwaysVisible" and it's working :sweat_smile: I already created a new PR, can you please try this?

Gnzlt commented 5 years ago

Could you try typing after that? I'm not able to introduce characters in the EditText 😅

Gnzlt commented 5 years ago

This is what happens when I test both approaches in a Pixel 2. How does it works for you?

Manifest tag Manifest tag + Request Focus
manifestonly requestFocus

Note: I get the same result on the left with your PR

malikmotani commented 5 years ago

It worked with Moto G4, but I checked it with Pixel, it isn't working as expected. Thanks for your contribution motog4

akashmi commented 5 years ago

@Gnzlt Can you please update your PR?