MindscapeHQ / raygun4android

Android crash reporting provider for Raygun
https://raygun.com
MIT License
21 stars 14 forks source link

Raygun Client using Activity reference for attaching pulse #46

Open aurangzaibumer777 opened 6 years ago

aurangzaibumer777 commented 6 years ago

RaygunClient.attachPulse(this); // taking an activity reference

Could'nt it use an applicationContext?

Since we attach it on SplashActivity meant it kept splashActivity alive throughout application lifecycle

using implementation 'com.mindscapehq.android:raygun4android:3.0.3' on build.gradle

TheRealAgentK commented 6 years ago

@aurangzaibumer777 That's good feedback, thx. I'm currently looking into making a bunch of changes to the provider and will consider this.