Migration to Gradle 8 and AGP 8.1.1

TheRealAgentK commented 10 months ago

Migration to Gradle 8 and AGP 8.1.1

Description :memo:

Fixes #89 and migrated the build over to Gradle 8 and AGP 8.1.1

Also fixes a bug where the sample app was outputting the incorrect provider version

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

Updates

Build to Gradle 8+
AGP to 8.1.1
Java target to Java 17 as required by Gradle 8
UI bug fix in sample app re provider version

Test plan :test_tube:

Project shouldn't trigger "Upgrade Gradle to 8" any more. Builds should all still work across debug and release flavours.

Note: Deprecation warning for Gradle 9+ still trigger and will be resolved separately.

Author to check :eyeglasses:

[x] Project and all contained modules build
[x] Tested on appropriate devices/emulators and SDK versions

~- [] Reviewed by another developer~ N/A

[x] Appropriate documentation written (code comments, internal docs)

Reviewer to check :heavy_check_mark:

[ ] Change has been tested on a device/emulator
[ ] Code is written to standards

~- [ ] Appropriate tests have been written (code comments, internal docs)~ N/A

sumitramanga commented 10 months ago

Yay!

sumitramanga commented 10 months ago

Will you be upgrading to the latest AGP in a later PR?

sumitramanga commented 10 months ago

Optional: It would be nice to have some feedback upon clicking the buttons within the providers test app. Such as, if you click there button, it should output some text that says 'Message sent' or 'Error sending message, check API key is valid'

TheRealAgentK commented 10 months ago

Will you be upgrading to the latest AGP in a later PR?

Yeah, the AGP versions are somewhat tied to AS versions.

I think we should update when new AS versions are released. Hedgehog is currently in RC and Iguana in Canary - when Hedgehog comes out of RC, we'll bump AGP up accordingly.

TheRealAgentK commented 10 months ago

Optional: It would be nice to have some feedback upon clicking the buttons within the providers test app. Such as, if you click there button, it should output some text that says 'Message sent' or 'Error sending message, check API key is valid'

Great suggestion:

https://github.com/MindscapeHQ/raygun4android/issues/98

sumitramanga commented 10 months ago

Will you be upgrading to the latest AGP in a later PR?

Yeah, the AGP versions are somewhat tied to AS versions.

I think we should update when new AS versions are released. Hedgehog is currently in RC and Iguana in Canary - when Hedgehog comes out of RC, we'll bump AGP up accordingly.

I had to do a bit of reading to understand this 😄 It all makes sense now. Thank you! Android has so many concepts to keep up with. Does this change have an impact on the customer side or does it affect just developers of the provider

sumitramanga commented 10 months ago

Testing of the app went well. It sends CR and RUM data after rebuilding the project 👏

sumitramanga commented 10 months ago

One more comment before I approve. Some of these changes have been added automatically due to the upgrade, right? I had attempted to upgrade the AGP just to see what happens and that's what happened :)

TheRealAgentK commented 10 months ago

One more comment before I approve. Some of these changes have been added automatically due to the upgrade, right? I had attempted to upgrade the AGP just to see what happens and that's what happened :)

Yeah, the wizard from 7.4to 8.1 gets you some way there luckily, but it's patchy and inconsistent as well.

TheRealAgentK commented 10 months ago

LGTM! 🤘

I'll make a few tweaks tomorrow re the small things we discussed and then merge it.

MindscapeHQ / raygun4android