MindscapeHQ / raygun4net

Raygun provider for .NET
https://raygun.com
MIT License
126 stars 93 forks source link

[APM-475] Remove APM profiler support from Raygun4Net.AspNetCore #449

Closed Deacon-McIntyre closed 3 years ago

Deacon-McIntyre commented 3 years ago

Raygun4Net will take over the APM sampling from the agent if Raygun4Net is installed into an app that has the APM profiler attached. This works for .NET Framework but will not work for .NET Core due to .NET Core’s asynchronous nature. In fact it will result in many traces being lost.

We are removing Raygun4Net’s sampling integration so that traces will behave as normal even when the application has Raygun4Net installed, because customers should be able to use APM and CR in the same application.

Testing

I added the Raygun4Net.ASpNetcore project to into the solution of a .NET Core test project, and manually sent an exception.

I also checked the sampling overrides are applied as expected while Raygun4Net was installed.