search

MindscapeHQ / raygun4net

Raygun provider for .NET
https://raygun.com
MIT License
125 stars 91 forks source link

Lack of ConfigureAwait(false) #451

Closed ceilingfish closed 3 years ago

ceilingfish commented 3 years ago

Hi, It seems that the Mindscape.Raygun4Net.NetCore.Common nuget package does not call ConfigureAwait(false) on any of it's await calls. This causes issues when the code is called from a single threaded execution context (such as web forms or WPF). Is there a reason these have been omitted, and would you consider adding them?

Havunen commented 3 years ago

such as web forms

To my understanding .net core does not support webforms, not sure how it is in WPF (.net core)

ceilingfish commented 3 years ago

Indeed webforms does not support .net core, however this library is targeting netstandard, which can be referenced from net framework

ceilingfish commented 3 years ago

I've had a go at resolving this in #455

krishnaKapadia commented 3 years ago

@ceilingfish This is definitely something that we would be happy to take a look at. Are you able to provide a quick example or description of the problem that you are experiencing? It will help me to further understand your use case as well as test your changes.

Cheers

JasenPalmer commented 3 years ago

Solved in #455