search

MindscapeHQ / raygun4net

Raygun provider for .NET
https://raygun.com
MIT License
125 stars 91 forks source link

fix: PEDebugInformation properties as nullable #539

Closed miquelbeltran closed 3 months ago

miquelbeltran commented 3 months ago

Part of the solution for the issue reported here: https://raygun.com/forums/thread/186975#187021

As discussed internally on Slack, when running a Raygun4MAUI client, we saw an issue in which the null check for the Signature property was not correctly done, and we had the suspicion that the compiler was optimizing the code because Signature was not declared as nullable, so the null check may be removed.

So I tried to set this as nullable, packaged a set of nupkg using the pack-all script, and imported them locally in the Raygun4MAUI solution. Then compiled and run the project (both directly in "debug" and as a "release" APK), and I couldn't reproduce the issue anymore following the same steps.

cc. @ProRedCat @PanosNB

miquelbeltran commented 3 months ago

Seems that this won't be necessary anymore, as discussed on Slack.