5.0.2 Release - Githubissues

MindscapeHQ / serilog-sinks-raygun

A Serilog sink that writes events to Raygun

Apache License 2.0

11 stars 20 forks source link

5.0.2 Release #39

Closed QuantumNightmare closed 3 years ago

QuantumNightmare commented 3 years ago

Changelog

Bug fix

When logging a null exception, the stack trace included in the Crash Report sent to Raygun will now correctly be the code execution stack up to the point where the log statement was made. This is functionality that was added in the previous version, but was erroneously using the code execution stack of a background thread.

QuantumNightmare commented 3 years ago

@nblumhardt When you get a chance, please review (and merge if approved) this new release that contains a single bug fix. As you'll see, the build script has failed due to being unable to push the dev build to NuGet.

QuantumNightmare commented 3 years ago

Thanks @nblumhardt, I've made the namespace change and pushed the new 5.0.2 version with this bug fix. I needed to edit the release from "v88" to "v5.0.2", so not sure if that's normal. I also changed the version of the dev branch to 5.0.3, but this pushed a pre release version to NuGet. Should that have been committed straight to the dev branch instead of through a PR?

nblumhardt commented 3 years ago

Direct to dev and a PR have the same effect - I think appending [skip ci] to the commit message sometimes/usually avoids publishing anything.

QuantumNightmare commented 3 years ago

Yeah, I did have [skip ci] in the commit to my branch at least. Maybe it needed to be in the PR name too in order to become part of the "Merge pull request" commit too.