cmake: use project-level variables, not top-level variables

Mindwerks / wildmidi

WildMIDI is a simple software midi player which has a core softsynth library that can be used with other applications.

https://github.com/Mindwerks/wildmidi

Other

201 stars 41 forks source link

cmake: use project-level variables, not top-level variables #214

Closed herrecito closed 4 years ago

herrecito commented 4 years ago

This PR replaces CMAKE_SOURCE_DIR and CMAKE_BINARY_DIR with PROJECT_SOURCE_DIR and PROJECT_BINARY_DIR. This is more correct. It makes possible to add WildMidi as a submodule in a parent project and link it with:

add_subdirectory(lib/wildmidi EXCLUDE_FROM_ALL)
target_link_libraries(main PRIVATE libwildmidi_static)

It should have no effect on WildMidi itself.

psi29a commented 4 years ago

Cool! Just needs a little love apparently...

herrecito commented 4 years ago

It should be OK now, though travis failed, but apparently while installing build dependencies on macOS?. I'm pretty sure is not related to this PR.

psi29a commented 4 years ago

Yeah, I'll have a look at the MacOS stuff when I have free cycles.

Thanks