search

Mindwerks / wildmidi

WildMIDI is a simple software midi player which has a core softsynth library that can be used with other applications.
https://github.com/Mindwerks/wildmidi
Other
201 stars 41 forks source link

pkg-config file is broken when CMAKE_INSTALL_{INCLUDE,LIB}DIR is absolute #236

Closed alexshpilkin closed 6 months ago

alexshpilkin commented 2 years ago

As per title: src/wildmidi.pc.in has

prefix=@CMAKE_INSTALL_PREFIX@
exec_prefix=${prefix}
libdir=${exec_prefix}/@CMAKE_INSTALL_LIBDIR@
includedir=${exec_prefix}/@CMAKE_INSTALL_INCLUDEDIR@

and so can’t handle absolute paths in CMAKE_INSTALL_{INCLUDE,LIB}DIR. This leads to a broken .pc file on NixOS in particular.

Similar to https://github.com/open-source-parsers/jsoncpp/pull/1199. See “Concatenating paths when building pkg-config files” for a discussion of the problem and a suggested fix (I don’t know CMake myself, sorry).

sezero commented 6 months ago

This should be fixed by https://github.com/Mindwerks/wildmidi/commit/c4a6330272174b80afac227f52699128afa02372: can you confirm?

If it's not fixed, or if there are further issues, please drop a note here.