Investigate crashes due to usage of grayscale-heightmap and rivers options

[ftomassetti]

whenever I use the parameters --grayscale-heightmap="..." or --rivers="..." the program crashes with the following output (of course I didn't just put in "..."):

--Linux output: Producing ouput:

• world data saved in '../generated_worlds/1616896804/1616896804.world'
• ocean image generated in '../generated_worlds/1616896804/1616896804_ocean.png'
• precipitation image generated in '../generated_worlds/1616896804/1616896804_precipitation.png'
• temperature image generated in '../generated_worlds/1616896804/1616896804_temperature.png'
• biome image generated in '../generated_worlds/1616896804/1616896804_biome.png'
• elevation image generated in '../generated_worlds/1616896804/1616896804_elevation.png' Traceback (most recent call last): File "", line 6, in File "/home/bcurtis/workspace/WorldEngine/worldengine/build/WE/out00-PYZ.pyz/cli.main", line 444, in main File "/home/bcurtis/workspace/WorldEngine/worldengine/build/WE/out00-PYZ.pyz/cli.main", line 71, in generate_grayscale_heightmap File "/home/bcurtis/workspace/WorldEngine/worldengine/build/WE/out00-PYZ.pyz/worldengine.draw", line 394, in draw_grayscale_heightmap_on_file File "/home/bcurtis/workspace/WorldEngine/worldengine/build/WE/out00-PYZ.pyz/worldengine.draw", line 145, in complete File "/home/bcurtis/workspace/WorldEngine/worldengine/build/WE/out00-PYZ.pyz/PIL.Image", line 1678, in save KeyError: ''

--Windows output: Producing ouput:

• world data saved in '../generated_worlds/695750035/695750035.world'
• ocean image generated in '../generated_worlds/695750035/695750035_ocean.png'
• precipitation image generated in '../generated_worlds/695750035/695750035_precipitation.png'
• temperature image generated in '../generated_worlds/695750035/695750035_temperature.png'
• biome image generated in '../generated_worlds/695750035/695750035_biome.png'
• elevation image generated in '../generated_worlds/695750035/695750035_elevation.png' Traceback (most recent call last): File "", line 6, in File "C:\workspace\worldengine\build\worldengine\out00-PYZ.pyz\cli.main", line 444, in main File "C:\workspace\worldengine\build\worldengine\out00-PYZ.pyz\cli.main", line 71, in generate_grayscale_heightmap File "C:\workspace\worldengine\build\worldengine\out00-PYZ.pyz\worldengine.draw", line 394, in draw_grayscale_heightmap_on_file File "C:\workspace\worldengine\build\worldengine\out00-PYZ.pyz\worldengine.draw", line 145, in complete File "C:\workspace\worldengine\build\worldengine\out00-PYZ.pyz\PIL.Image", line 1678, in save KeyError: ''

[psi29a]

This looks like fun... pay no attention to the paths, that isn't the problem.

@ftomassetti have you managed to reproduce this (binary and straight from source).

[ftomassetti]

nope, I did not tried yet

[psi29a]

Isn't a crash, but rather PILLOW (PIL) that only looks at the extension of the filename to determine what format to save the image (river or greyscale) to. So a bad extension 'crap' from "blah.crap" will throw a keyerror because crap doesn't exist.

I catch this error, and append a 'png' along with an message saying why.

I also try looking for '.' in the filename at the start and verify it exists, otherwise error out with message why.

[ftomassetti]

Thanks!