search

Mindwerks / worldengine

World generator using simulation of plates, rain shadow, erosion, etc.
MIT License
982 stars 128 forks source link

Seed fix #127

Closed tcld closed 8 years ago

tcld commented 8 years ago

A very small change. I found it very confusing that the parameter "seed=0" resulted in a random seed even though internally 0 is a perfectly valid seed value. Since negative parameters should be equally valid anyway, only cutting out 0 seemed like an oversight.

Also, I changed 65536 to 65535. randint() includes its boundaries, so the former number results in a range of 2^16+1 (and it really looked like it was meant to be 2^16). Extremely minor and unimportant, I guess. But I was already changing the code anyway...

ftomassetti commented 8 years ago

Looks good to me. @tcld thank you, you are doing a lot of great work for this project!

tcld commented 8 years ago

Well, this is a really small patch. I compiled an ran it by now, generated some worlds - so far everything seemed to work.

ftomassetti commented 8 years ago

Cool, I think we can merge this one. @psi29a let me know if it is a problem and I will revert it

ftomassetti commented 8 years ago

By the way we should also add you to the contributors in the README. Feel free to open a PR with the desired changes (your name, and the area you worked on, as we did for others contributors)

tcld commented 8 years ago

Should I ever feel that's necessary, I will do that. Thanks. :)