search

Mindwerks / worldengine

World generator using simulation of plates, rain shadow, erosion, etc.
MIT License
982 stars 128 forks source link

Rework of GDAL-export #159

Closed tcld closed 8 years ago

tcld commented 8 years ago

This originally went into https://github.com/Mindwerks/worldengine/pull/141 (which happened due to me working on too many things at once). I now separated it to make things easier for everybody.

I decided to make some rather big changes to the way GDAL export is handled: I think the commandline interface is now a little bit easier to use, and the changes to imex/__init__.py actually allow the user to make use of every format GDAL can handle while hopefully not making things more complicated than they were before.

I based this off of https://github.com/Mindwerks/worldengine/pull/146 even though it wasn't strictly necessary. I figured that discussing the changes happening here would take longer than merging the other PR anyway. Here the link to the only commit that is relevant: https://github.com/Mindwerks/worldengine/commit/b8d098fc14df1f4eecb8266a731cc6edf7d7572c

tcld commented 8 years ago

The tests failed, something about recursion depth. On my system all tests were passed - can somebody help me out?

tcld commented 8 years ago

I did a rebase so now the code is cleanly separated from other work.

ftomassetti commented 8 years ago

Given @psi29a worked on GDAL stuff I would wait for his comments. This one is not urgent, right?

tcld commented 8 years ago

This one is separated from everything else - unless somebody starts working on GDAL himself, this can wait.

psi29a commented 8 years ago

I like what I see and makes a few things simpler.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.4%) to 83.621% when pulling c9bcc5c6f7713fa457645b67a5a0af75d98c7e03 on tcld:gdal_chng into c8b6ad0bf602944c4d58f888bba6fac296de1fdd on Mindwerks:master.