search

Mindwerks / worldengine

World generator using simulation of plates, rain shadow, erosion, etc.
MIT License
982 stars 128 forks source link

Fixes to make pyflakes- and manifest-tests run again. #160

Closed tcld closed 8 years ago

tcld commented 8 years ago

Problem described here: https://github.com/Mindwerks/worldengine/issues/158

I used @psi29a 's suggestion regarding the addition to MANIFEST.in.

tcld commented 8 years ago

About the tests: The ancient map-stuff should pass once the RNG-changes are merged.

However, the manifest-tests still fail: https://travis-ci.org/Mindwerks/worldengine/jobs/88091783 Does somebody know what do do about it?

tcld commented 8 years ago

@psi29a: Do you maybe have a hint about what to do to make the manifest-test pass again?

tcld commented 8 years ago

I read a bit about MANIFEST.in and how it works and both of the optional tests can now be passed again. I excluded the docs-directory (and thus Biomes.html) in MANIFEST.in - is that the right way to go? If so, this could be merged to make two of the tests run again.

Maybe one of you can have a look at the (tiny) changes, @ftomassetti or @psi29a ? I also wouldn't mind making the pyflakes-test a non-optional test, since it provides very clear instructions on what to change (and so far it has proven quite useful in my opinion).

ftomassetti commented 8 years ago

I think we should include the docs directory in MANIFEST.in, so that the user downloading the package have also the docs.

ftomassetti commented 8 years ago

Aside from including the docs all the rest seems good to me

tcld commented 8 years ago

So I should use recursive-include instead? I am not sure if the the test will pass then, but I can try.

tcld commented 8 years ago

Ok, it seems to work.

ftomassetti commented 8 years ago

cool, merging