search

Mindwerks / worldengine

World generator using simulation of plates, rain shadow, erosion, etc.
MIT License
982 stars 128 forks source link

numpy-replacements for image-drawing #161

Closed tcld closed 8 years ago

tcld commented 8 years ago

Another portion of the code in https://github.com/Mindwerks/worldengine/pull/141 . Some very small changes and quite a lot of changes in the draw- and drawing_functions-modules.

This again is based off of https://github.com/Mindwerks/worldengine/pull/146 .

Tests will fail for now due to some differences in rounding for the grayscale-map.

ftomassetti commented 8 years ago

we still want to merge this, right? Rerunning the tests

tcld commented 8 years ago

Sure.^^ I closed the PR that doesn't have to be merged, these new ones are the replacements. I did a rebase, too, so now the changed code actually reflects what has been changed.

tcld commented 8 years ago

Updated.

tcld commented 8 years ago

Except for the difference in rounding of the heightmaps (line 229 of this PR) this passes the tests and is otherwise finished. I added another PR to worldengine-data https://github.com/Mindwerks/worldengine-data/pull/8 (even though the heightmaps will be changed again when moving them to 16 Bit) and then this is as ready is it gets (aside from code-critique).

tcld commented 8 years ago

Rebased and conflicts solved.

ftomassetti commented 8 years ago

Some minor comments but it seems good to go, sorry if it took a while to review it

tcld commented 8 years ago

Changes are up, hopefully it's fine now.

tcld commented 8 years ago

Oh, and don't forget: For this to pass the tests, worldengine-data needs to be updated (https://github.com/Mindwerks/worldengine-data/pull/8).

ftomassetti commented 8 years ago

Ok, I ran the code locally with the patch for worldengine-data and this one and tests pass. Merging both.