search

Mindwerks / worldengine

World generator using simulation of plates, rain shadow, erosion, etc.
MIT License
982 stars 128 forks source link

fix loading pickle files #167

Closed ftomassetti closed 8 years ago

ftomassetti commented 8 years ago

Apparently loading pickle files does not work anymore. Fixing. Also adding a few spaces before the name of the operation, so that everything is aligned.

tcld commented 8 years ago

It didn't work? At least one of the files used by the unit tests is a pickle file, and I never noticed any problems. Or was it just with user-loaded pickle files?

EDIT: The ancient map tests failed (for one of the Travis tests...why are there two?). Some of my PRs fail them due to a difference in rounding, here I don't see the reason.

ftomassetti commented 8 years ago

it was with user loaded pickle files: we have a function which look at a world file and try to guess if it is a pickle file or a protobuf file and depending on that load the world with a different function. The issue was with the function recognizing the type of file. Perhaps in the tests we call directly the method to load a file from pickle.

ftomassetti commented 8 years ago

It is failing because of changes with the blessed images.

tcld commented 8 years ago

You are right about the way the pickle files are loaded in the tests.

I wouldn't mind if you just merged this, if that isn't against standard procedure. The change is kind of small.^^

ftomassetti commented 8 years ago

168 was built on top of this so no need to merge this one separately