Mindwerks / worldengine

World generator using simulation of plates, rain shadow, erosion, etc.
MIT License
981 stars 127 forks source link

Update README.md #170

Closed esampson closed 8 years ago

esampson commented 8 years ago

Made suggested changes. No clue why this would cause a coveralls decrease since it doesn't affect any of that.

tcld commented 8 years ago

I was told that coveralls is a bit random - sometimes the result changes between basically empty commits.

I hope the others are fine with the removal of the exemplary output, since there was no further comment about it. (I like it, of course.^^)

esampson commented 8 years ago

It actually isn't all that random, as I understand it. I mean, sure, if all you do is run the program once and then see what lines of code run and what don't it can be a bit random since not every biome will be generated. We take a lot of the randomness out of it, however, by doing more comprehensive tests that do things such as force all biomes to be evaluated.

tcld commented 8 years ago

By the way: I noticed that you (?) added a biome testworld to worldengine-data. I don't know what's in there, but should it have to be regenerated at some point...how would one do it? You might want to add some sort of instruction (or add a line to data_generator.py).

esampson commented 8 years ago

Yes, that was me and no, it shouldn't need to be regenerated any time in the foreseeable future. It is a small world (I think it is 256x256) that was generated with an increasing temperature going from west to east and increasing humidity going from north to south (or something very similar. I may have the directions wrong).

As a result the world has all possible biomes while maintaining a small size. This lets tests be run with the certainty that every biome is encountered so that we know that there's no errors in any of that code (and it also decreases the randomness of the coverage test).

esampson commented 8 years ago

Oh, the world also has no ocean so there would be no danger that one of the biomes that needed to be tested was underwater.

ftomassetti commented 8 years ago

LGTM, thanks!