search

Mindwerks / worldengine

World generator using simulation of plates, rain shadow, erosion, etc.
MIT License
988 stars 129 forks source link

Added command line options for temperature/precipitation gamma correction curve. #171

Closed esampson closed 8 years ago

esampson commented 8 years ago

Also minor code cleanup.

Modified scatter plot to show gamma correction curve.

tcld commented 8 years ago

I noticed something: In the current master-branch https://github.com/Mindwerks/worldengine/blob/master/tests/data/data_generator.py is broken due to missing parameters. You probably overlooked that file in the PR preceding this one. It would be nice if you could double-check that it works with this PR. (And it would be nice if this PR then could be merged as soon as possible. ;) )

esampson commented 8 years ago

Added a routine to print warnings. Added warnings for unusual but legal assignments for humidity and temperature ranges. Added error catching for gamma value and gamma offset.

tcld commented 8 years ago

Good job on that front. :) I hope that we can at some point tackle "global variables" in a way that shortens that code a bit (or rather puts it somewhere else^^).

(Also, please don't overlook my last comment.)

esampson commented 8 years ago

Ok. Fixed data_generator.py by adding defaults to _plates_simulation. Also added a coverage test for the new warnings systems.

ftomassetti commented 8 years ago

Thanks for adding the warnings!

ftomassetti commented 8 years ago

No idea why AppVeyor failed. Restarting it.

ftomassetti commented 8 years ago

Apparently the last build was killed because it was taking too long (and it was taking too long during the setup phase). I do not see a way to restart the build.

psi29a commented 8 years ago

Bumped it for a rebuild. First log-in, then you can get the rebuild button. :)

ftomassetti commented 8 years ago

All the tests passing. Merging. Thanks to everyone!