Closed j-coppola closed 8 years ago
Thank you for going through the effort of re-preparing the pull-request: it is appreciated. Git drove all of us mad at the beginning (honestly, it still does from time to time...)
Aside from small comments this looks really, really good. Should you need help ironing out my 'complaints', just ask. :)
I think freezing oceans would be a very nice addition but perhaps we could that in a second step. It would be cool to address some of the issues, merge the patch and then have a few incremental improvements. In this way we could have this very cool feature going in the next release and then improve it later.
@pangal would be ok for you if we list you among the contributors?
I'd be honored to be listed as a contributor!
I may see if I get reasonable results by freezing the ocean when I have time later today.
Wooo... frozen oceans!
Looks good now. The only things I noticed were a couple unnecessary spaces that were added and the missing newline at the end of draw.py.
PS: I will take care of the seed-value in generation.py. #183 PPS: I hope that doesn't cause problems when merging.
PPPS: Appveyor complains, but the problem seems a bit mysterious to me. Maybe it'll fix itself after the next commit?
Travis took over 1h to run so it was killed. Restarting it
I mean, I would restart it if it would let me do so... However I do not see any reasons why the build should be broken on Windows by this.
I would like to thank you a lot @pangal for proposing this patch and for working on it, adding comments and following the suggestions. I would like to thank you also @tcld who carefully reviewed, commented and helped us having this patch in better shape. Time to merge, add @pangal to the contributors. And we should also add @tcld : plase @tcld add yourself to the README!
I started a commit for the README but didn't know what to write yet. I will do it before the next release.
Here is a pull request with the proper issues sorted out.
This branch adds functionality for creating a "Satellite map" of the generated world. This is currently an option, default false, toggled on with the --sat command when running.
Additional work may need to be done in selecting more appropriate biome colors and tuning the algorithm to display elevation / shading, to get a more realistic result.
Some sample outputs are attached here:
![8e177a62-819c-11e5-8452-9a03a9fa8734](https://cloud.githubusercontent.com/assets/8039081/10930438/f5b50ad2-8272-11e5-8e90-5153600301a3.png)