search

Mindwerks / worldengine

World generator using simulation of plates, rain shadow, erosion, etc.
MIT License
988 stars 129 forks source link

pickle: protobuf: make protobuf the default format instead of pickle #187

Closed ftomassetti closed 8 years ago

ftomassetti commented 8 years ago

Solve #65

psi29a commented 8 years ago

Can we just drop 'official' support of pickle, as in in the params? We leave the code to handle pickle worlds until 0.20 ?

ftomassetti commented 8 years ago

sure, done

ftomassetti commented 8 years ago

Cool, one to go before closing all the issues for v0.19.0

tcld commented 8 years ago

@ftomassetti and @psi29a: I just realized that removing the ability to save pickle-files kind of makes it impossible to generate test-worlds in the pickle-format. So either there needs to be some kind of backdoor or the pickle-tests etc. should be removed, too. (I think only the latter makes sense since loading of old pickle-worlds will fail anyway once there has been any sort of change to the save files. So the end-user won't have any advantage from residual pickle-support).

psi29a commented 8 years ago

The later is the best, it should also be purged. Pickle tests can go away.

tcld commented 8 years ago

I took some time and removed pickle completely: https://github.com/Mindwerks/worldengine/pull/192