Removed (almost) every last trace of support for pickle

Mindwerks / worldengine

World generator using simulation of plates, rain shadow, erosion, etc.

MIT License

988 stars 129 forks source link

Removed (almost) every last trace of support for pickle #192

Closed tcld closed 8 years ago

tcld commented 8 years ago

Since I wanted to add a new variable to the World I noticed that I couldn't regenerate the pickle test-worlds after https://github.com/Mindwerks/worldengine/pull/187 had been merged (I did it via a bash-script before, but WorldEngine didn't take a parameter to output a pickle-world anymore). After a bit of thinking I noticed that "load-only support" for pickle is worthless once new variables are added to the world since compatibility will most likely be lost anyway; @psi29a seemed to agree that pickle-support could probably be purged completely.

So what this does might seem a lot:

completely remove pickle-support
update data_generator.py so it actually outputs all necessary data (should have done that earlier)
also updated the worlds data to use a single world-file with seed 28070 instead of four different files (I didn't see the purpose; comments on that are welcome)
removed two tests that seemed useless now

EDIT: Data for this PR

tcld commented 8 years ago

I would prefer if https://github.com/Mindwerks/worldengine/pull/185 could be merged before this one, so I don't have to regenerate the data for that PR. My other PRs can't be merged before this one since I wouldn't be able to generate the data needed for them. Pickle has to go first (or somehow fixed so that test-worlds can be generated again).

EDIT: I'm stupid, I'll have to regenerate one of the data-sets anyway. So I guess it doesn't matter at all which were to be merged first.

tcld commented 8 years ago

The tests are passed, of course. But the data should still be updated to at least remove the now unneeded binary files.

tcld commented 8 years ago

Comments removed. (Since the data has already been merged, this should probably be merged soon, too.)

ftomassetti commented 8 years ago

LGTM, I will award it will the "ship-it-squirrel" :shipit:

ftomassetti commented 8 years ago

Let's wait for tests to pass and merge this

tcld commented 8 years ago

What's a "shipt-it-squirrel"? Maybe I should have been more clear about the order in which things should be merged?

Tests will pass within the next two or three minutes, I guess. Already almost done.

ftomassetti commented 8 years ago

It is something that is used at GitHub to show support for a PR (https://www.quora.com/GitHub/What-is-the-significance-of-the-Ship-It-squirrel).

Do no worry about that! Having the separate repositories for code and data these things happen and it will be solved soon.

tcld commented 8 years ago

Ah, ok. (I think the tests just restarted. I was looking at the log of the almost finished tests, now it is back to square one. So...another at least ten minutes, I guess. The tests here are even slower than on my old laptop.^^)

ftomassetti commented 8 years ago

Ok, tests are passing. Let's merge this one!