Satellite-view as standard output; a bit of clean-up

Mindwerks / worldengine

World generator using simulation of plates, rain shadow, erosion, etc.

MIT License

988 stars 129 forks source link

Satellite-view as standard output; a bit of clean-up #197

Closed tcld closed 8 years ago

tcld commented 8 years ago

I wanted to make the satellite-view a standard output; while working on it I cleaned up very few lines of code.

I also noticed that generation including the new outputs (satellite and scatter) now takes roughly 50% longer than it took exactly four weeks ago. The satellite-view is probably slow, but I assume that something else changed. The speed is still not bad, we are now at twice the speed of 0.18. But maybe somebody has an idea of what to improve.

psi29a commented 8 years ago

What do you mean that we are double the speed of 0.18? Is that faster or slower, the direction is clear in your post. ;)

Do we really want to output everything by default? ;)

tcld commented 8 years ago

I only made the satellite-view a default, and I don't think that's debatable.^^

"Double the speed" == "faster" ;P Generation for me now takes about half as much time as in 0.18, including several of the optional outputs. But four weeks ago, I only needed 66% of the time I need now. So things got a little slower again.

tcld commented 8 years ago

Tests here should be fine after #189 is merged.

psi29a commented 8 years ago

This branch has conflicts that must be resolved

tcld commented 8 years ago

Conflicts gone.

ftomassetti commented 8 years ago

I think we should consider what images to generate automatically and which not. It makes probably more sense to generate the satellite view by default and disable temperature, precipitation and ocean images. We could then add operations to generate specific images from the world file. I would suggest we retarget this to the next release.

tcld commented 8 years ago

Most of the images take about a second to be written, I am not sure if we wouldn't just be overcomplicating things by adding in more options etc.

psi29a commented 8 years ago

We are changing the default behaviour, I think this PR can wait until after 0.19 release. :)

This is a library that also happens to have a CLI, as a CLI was should be able to show off as many features of the library as possible.

The GUI on the other hand can be stream-lined... however we need someone who has experience in UX to help design it. Or we just imitate/emulate others. ;)

tcld commented 8 years ago

What do you mean by 'default behaviour' here? How about renaming --sat to --no-sat instead (and setting the corresponding default value to False, i.e. a satellite-image is created)? Would that be acceptable?

If you are talking about worldengine-gui, did anybody try to use it lately? I haven't, but it would probably be a good idea to see if it agrees with all the recent changes to worldengine.

psi29a commented 8 years ago

I was just giving an example about the GUI. It should still work as-is, since it was bare-bones to begin with.

tcld commented 8 years ago

I will close this for now. The cleanup-part has been snuck into one of my other PRs, and making the satellite a standard output could be easily done any time while also being slightly debatable due to the time it takes to be generated.

coveralls commented 7 years ago

Coverage increased (+0.1%) to 85.845% when pulling 8c5dee40dd47f72f20771d6847450353af0e7b76 on tcld:rel_pol2 into 3e8030e8c9966054196086e33a90aa559b933544 on Mindwerks:master.