Mindwerks / worldengine

World generator using simulation of plates, rain shadow, erosion, etc.
MIT License
981 stars 127 forks source link

world.plates->numpy, some optimizations #201

Closed tcld closed 8 years ago

tcld commented 8 years ago

It seems I overlooked an array when making the other arrays numpy-arrays. I stumbled over this after noticing that center_world(), for some reason, returned different results for Python 2 and 3 when I generated the following test-world. That is fixed with this, too.

width=1024
height=768
plates=3
ocean=0.71
seed=13051

Short summary of the changes in here:

PS: Sorry for still doing stuff that is not related to an immediate release!

psi29a commented 8 years ago

This actually looks like it should be included, because it falls under the mandate of 'use numpy, everywhere!'.

@ftomassetti wouldn't you agree?

ftomassetti commented 8 years ago

@psi29a I have nothing against it and the code seems ok to me, feel free to merge it!

tcld commented 8 years ago

Comments taken care of. I also removed another test + function since it wasn't used anywhere (and, like matrix_min_and_max(), had a numpy counterpart).

ftomassetti commented 8 years ago

Let's merge #198 and then this one before changing release number and tagging the new release