Mindwerks / worldengine

World generator using simulation of plates, rain shadow, erosion, etc.
MIT License
981 stars 127 forks source link

Convert setters to properties #236

Closed Himura2la closed 7 years ago

Himura2la commented 7 years ago

Trying to be helpful and resolve #209 I did not run this project, so the code is need to be carevully reviewed and tested

ftomassetti commented 7 years ago

Any reasons why you did not run the automated tests locally?

Himura2la commented 7 years ago

To be honest, I don't have experience in unit testing. I tried to run python -m unittest but it discovered 0 tests. Maybe that's because I can't install noise==1.2.2, pip throws some random error

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.3%) to 86.036% when pulling 9c6a3c1eb4655a4fe4bc5c35b2b553d2bd43f228 on Himura2la:master into d7604c9be043916d67ff441da863fc102bf5ab98 on Mindwerks:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.3%) to 86.036% when pulling 9c6a3c1eb4655a4fe4bc5c35b2b553d2bd43f228 on Himura2la:master into d7604c9be043916d67ff441da863fc102bf5ab98 on Mindwerks:master.

codecov-io commented 7 years ago

Current coverage is 80.94% (diff: 65.71%)

Merging #236 into master will increase coverage by 0.26%

@@             master       #236   diff @@
==========================================
  Files            28         28          
  Lines          3819       3867    +48   
  Methods           0          0          
  Messages          0          0          
  Branches        764        764          
==========================================
+ Hits           3081       3130    +49   
+ Misses          546        541     -5   
- Partials        192        196     +4   

Powered by Codecov. Last update d7604c9...9c6a3c1

ftomassetti commented 7 years ago

To me it looks good and tests are passing. I will leave it open to give the possibility to @psi29a to take a look. If I do not hear anything in the next days I am going on to merge this one.

In the meantime: @Himura2la thank you very much for your work, it is appreciated!

Himura2la commented 7 years ago

Thanks for your opensource work!

psi29a commented 7 years ago

LGTM, merging! :)

Thank you very much!

psi29a commented 7 years ago

Feel free to add yourself to the list of contributors! :)