Closed Himura2la closed 7 years ago
Any reasons why you did not run the automated tests locally?
To be honest, I don't have experience in unit testing. I tried to run python -m unittest
but it discovered 0 tests. Maybe that's because I can't install noise==1.2.2
, pip throws some random error
@@ master #236 diff @@
==========================================
Files 28 28
Lines 3819 3867 +48
Methods 0 0
Messages 0 0
Branches 764 764
==========================================
+ Hits 3081 3130 +49
+ Misses 546 541 -5
- Partials 192 196 +4
Powered by Codecov. Last update d7604c9...9c6a3c1
To me it looks good and tests are passing. I will leave it open to give the possibility to @psi29a to take a look. If I do not hear anything in the next days I am going on to merge this one.
In the meantime: @Himura2la thank you very much for your work, it is appreciated!
Thanks for your opensource work!
LGTM, merging! :)
Thank you very much!
Feel free to add yourself to the list of contributors! :)
Trying to be helpful and resolve #209 I did not run this project, so the code is need to be carevully reviewed and tested