Closed MM1nd closed 6 years ago
The code looks good to me. I would first merge the changes into the blessed images (PR to worldengine-data) and then rerun the tests here. As they pass I would merge this PR. Does it make sense?
I agree, if you would like to update the blessed images first, we can compare the differences there too.
Restarting build...
Merging #251 into master will decrease coverage by
0.15%
. The diff coverage is81.25%
.
@@ Coverage Diff @@
## master #251 +/- ##
==========================================
- Coverage 79.76% 79.61% -0.16%
==========================================
Files 28 28
Lines 3617 3595 -22
Branches 715 709 -6
==========================================
- Hits 2885 2862 -23
- Misses 543 544 +1
Partials 189 189
Impacted Files | Coverage Δ | |
---|---|---|
worldengine/drawing_functions.py | 79.7% <81.25%> (-1.11%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update eec3895...c8b274b. Read the comment docs.
Coveralls is not happy... but the tests pass. :)
Merged, this is great work. Thank you for taking the time!
Please take the time to update the README Contributors section to add your own blurb about yourself. :)
This fails the test as discussed in #250
The blessed image would have to be changed. It is two full minutes (~66%) faster on a 1024*512 map on my machine though.