Mindwerks / worldengine

World generator using simulation of plates, rain shadow, erosion, etc.
MIT License
981 stars 127 forks source link

improved mountain mask #252

Closed MM1nd closed 6 years ago

MM1nd commented 6 years ago

In absolute timing this takes about 10s off the clock for a 1024*512 map. Relative timings are dominated by anti-aliasing, but I thought I'd do this while waiting for #251 to be resolved.

Code is also a bit cleaner, once again.

Not much more to be said about this one.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.1%) to 85.011% when pulling 99ed82f2c6e3849da0585d8a5a5330a9d2f77633 on MM1nd:mountains_mask into 20d93d97fdd5998730d9220be83aa4512843c6dd on Mindwerks:master.

codecov-io commented 6 years ago

Codecov Report

Merging #252 into master will increase coverage by 0.86%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #252      +/-   ##
=========================================
+ Coverage   79.64%   80.5%   +0.86%     
=========================================
  Files          28      28              
  Lines        3620    3617       -3     
  Branches      721     715       -6     
=========================================
+ Hits         2883    2912      +29     
+ Misses        547     511      -36     
- Partials      190     194       +4
Impacted Files Coverage Δ
worldengine/common.py 85.05% <100%> (+0.17%) :arrow_up:
worldengine/drawing_functions.py 80.8% <100%> (ø) :arrow_up:
worldengine/model/world.py 75% <100%> (+0.66%) :arrow_up:
worldengine/simulations/erosion.py 69.96% <0%> (+10.67%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 20d93d9...9d7d214. Read the comment docs.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+1.0%) to 85.872% when pulling 9d7d2147bf190a8c17433b5ad31482a9dc579108 on MM1nd:mountains_mask into 20d93d97fdd5998730d9220be83aa4512843c6dd on Mindwerks:master.

psi29a commented 6 years ago

Nice work! Those nested loops are gone which is a big win for simplicity. Thank you again. :)