search

Mine-and-blade-admin / Battlegear2

GNU General Public License v3.0
54 stars 54 forks source link

API includes call to non-API class #51

Closed Zerokyuuni closed 10 years ago

Zerokyuuni commented 11 years ago

/battlegear mod src/minecraft/mods/battlegear2/api/heraldry/HeraldryData.java includes a call in a finally block to /battlegear mod src/minecraft/mods/battlegear2/utils/BattlegearUtils.java, and as finally always runs once a try-catch is finished regardless of the outcome, not having BattlegearUtils (and what it depends on, and so on and so forth) will cause a crash at compile time if just the API is present

GotoLink commented 11 years ago

You can have the entire mod source to develop with. Only interact with the API though, as other parts are likely to change, especially the heraldry.

aaron-edwards commented 11 years ago

Thanks for flagging this, you are right that it really shouldn't be in there (I basically did a "dumb" search for places where streams needed to be closed). Removing the call and instead simply re-writing the method inside the heraldry data class should fix the issue.

For the moment the heraldry system is still being worked out so please do not use it anyway.