Should temperature typehint be `int` or `float`? - Githubissues

MineDojo / Voyager

An Open-Ended Embodied Agent with Large Language Models

https://voyager.minedojo.org/

MIT License

5.36k stars 492 forks source link

Should temperature typehint be `int` or `float`? #83

Closed nero19960329 closed 1 year ago

nero19960329 commented 1 year ago

Before submitting an issue, make sure you read the FAQ.md

Briefly describe your issue

I found that temperature's typehint at voyager/voyager.py are int, but its typehint in langchain is float, which is different.

https://github.com/hwchase17/langchain/blob/master/langchain/chat_models/openai.py#LL142C5-L142C16

Please provide your python, nodejs, Minecraft, and Fabric versions here

...

[If applicable] Please provide the Minefalyer and Minecraft logs, you can find the log under `logs` folder

...

[If applicable] Please provide the GPT conversations that are printed each round.

...

xieleo5 commented 1 year ago

Sorry about this typo, it should be float. Fixed in the latest commit.