search

MineInAbyss / Mobzy

Config-driven custom mobs for Spigot using ECS
https://mineinabyss.com/Mobzy/
MIT License
41 stars 7 forks source link

NPC minecart kidnapping #36

Closed 0ffz closed 3 years ago

0ffz commented 3 years ago

Although NPCs have movement disabled by overriding those functions, we forgot to disable picking them up into minecarts.

We should figure out what method corresponds to getting picked up into minecarts and override it to do nothing. Ideally we'd actually have components for disabling movement or minecart pickup, though they would likely have to use events, and I'm not too sure that we can consistently catch every use case that way.

We could also override these methods in MobBase to check whether the component is present and prevent it from triggering if it isn't.

pixelfac commented 3 years ago

I submitted prs https://github.com/MineInAbyss/Mobzy/pull/37 and https://github.com/MineInAbyss/server-config/pull/14 to cover this issue

Boy0000 commented 3 years ago

Merged with #37