search

MineLittlePony / HDSkins

The Minecraft HDSkins mod from the VoxelModPack team brought to you by the Horse team
http://minelittlepony-mod.com
MIT License
33 stars 10 forks source link

Incompatibility with Iris mod. #45

Closed RowanSkie closed 2 years ago

RowanSkie commented 3 years ago

The full details here:

https://github.com/IrisShaders/Iris/issues/489

EDIT: Basically, shader mod seems to be unable to run with Kirin UI/HDSkins.

Sollace commented 3 years ago

This appears to be a problem with Iris. They need to ensure their code works when rendering an entity model from the main menu.

No doubt there will be other mods that could cause incompatibilities in the same way.

Sollace commented 3 years ago

There doesn't appear to be any public builds of Iris for 1.17. Can you please link me to where you were able to download that mod from?

RowanSkie commented 3 years ago

The download is actually seen on its Modrinth page.

Sollace commented 3 years ago

Tested the fix with the changes in https://github.com/MineLittlePony/HDSkins/commit/ee78ad6e38695163c827777b642f63d1cbb7ff39 with Iris (both with and without Sodium) and it appears to be resolved. I will be keeping this open, though, as there is an unresolved issue with Iris.

RowanSkie commented 3 years ago

You know, I tried the fix with my own compiled build of the latest merge, and it certainly didn't CTD itself out now.

RowanSkie commented 3 years ago

Iris and Iris-forked Sodium just updated, which I tested and immediately crashed when I load the HD Skins screen again before world view.

Sollace commented 3 years ago

@RowanSkie Did you use the custom buuld of HDSkins that you said was working?

RowanSkie commented 3 years ago

Well, it was the latest pull you created after all, but yeah it did.

Sollace commented 3 years ago

Tested and appears to be working with the version of iris found on modrinth (over here: https://modrinth.com/mod/iris/version/lAEtBzCu )

Sollace commented 2 years ago

Reopening this, as Iris seems to have broken something again.