search

MineMaarten / AdvancedMod

A repository that holds the Advanced Mod. This is a tutorial mod which progresses further than the basic modding tutorials out there. You can follow the series here: https://www.youtube.com/playlist?list=PL5oCR-MRH-12rXI0USklAz6rQagXr4nl5
GNU General Public License v3.0
23 stars 8 forks source link

Liquids pls #2

Closed MSourceCoded closed 9 years ago

MSourceCoded commented 9 years ago

git gud

MSourceCoded commented 9 years ago

Don't merge this, I'm going to do a tutorial video on Git Pull Requests in response to your Advanced Modding series if that's all good?

MineMaarten commented 9 years ago

Sure!

Hmm...... I did look at BlockLiquid, even while I was recording, but when I was looking if Vanilla was using BlockLiquid I came to the conclusion it didn't.... But now I'm looking at it again it does >.>.

But tell me what you want me to do, I won't merge until you say, but it looks good to be merged :P

MSourceCoded commented 9 years ago

Just a video showing how to PR (you can't since you're the owner of the repository :P), using this code fix as an example. Feel free to close this one when you're ready, and I'll film the video today ^^