MineMaarten / IGW-mod

ModJam 3 mod, In-Game Wiki Mod
GNU General Public License v2.0
16 stars 21 forks source link

Null ItemStack fixes #83

Closed desht closed 6 years ago

desht commented 6 years ago

As of MC1.11, ItemStack.EMPTY should always be used instead of 'null'.

This specifically fixes an interaction problem with the Item Scroller mod, where rolling the mouse wheel over a container slot in the wiki crashes the client.

Longer term I'd recommend going through any methods which take or return an ItemStack and annotating those parameters & returns with @Nonnull, but this PR will fix any immediate problems.