search

MineMaarten / PneumaticCraft

PneumaticCraft source
Other
84 stars 50 forks source link

Add option in block condition to ignore fluids #760

Closed Forecaster closed 8 years ago

Forecaster commented 8 years ago

Currently the block condition checks for any block, which includes fluids.

My mining program has a subroutine dedicated to scanning the mining area using foreach and testing if each block is a fluid block, and if it is the drone will go there to have the security upgrade destroy it. This just because fluid blocks interfere with the block conditions that check if each sub-job is done by seeing if there are blocks left to dig out.

But looping through each block in the mining area takes a very long time. It would be great if the block conditions would simply ignore fluids, since they cannot be dug, and you cannot exclude them using item filters.

PS. The subroutine also checks the entire area for fluids first, and if there are no fluids in it it wont have to loop through it.

MineMaarten commented 8 years ago

This sounds like this is ideal in your case, but for other users it simply doesn't make sense to let fluid blocks act like air...

AEnterprise commented 8 years ago

maybe an upgraded one then or an option? there are cases where it would be usefull for plenty of people

Forecaster commented 8 years ago

Have it be an "Ignore Fluids" option like "Check for Air"?

Since the fluid condition now checks for fluid blocks I don't see why the block condition has to as well.