search

MineMaarten / PneumaticCraft

PneumaticCraft source
Other
84 stars 50 forks source link

Oil Buckets not compatible with other tank mods #785

Closed Ampflower closed 8 years ago

Ampflower commented 8 years ago

When playing this with lots of other mods, the oil bucket is very incompatible with tanks and other mods that can drain and fill buckets. Idea is if the bucket is compatible, it wouldn't be a annoy at all with pumps from other mods, and trying to fill a tank with oil. I really think of this as a nasty bug because you can't drain a tank with this mod's oil in it and fill a tank with this oil bucket.

MineMaarten commented 8 years ago

I can't really do anything with this I'm afraid. Could you give me instructions to reproduce this? Which mods is it incompatible with? How does it fare on a clean world?

Ampflower commented 8 years ago

To reproduce it is if you have another mod installed with a tank, like Extra Utilities Drums, try rightclicking the drum with the oil bucket, or if there is oil in there because of pump, it can't find the bucket for the fluid.

MineMaarten commented 8 years ago

We had this issue on a 1.8 test server, and I know the cause, it was there in 1.7 too. I'll look at backporting the fix.

MineMaarten commented 8 years ago

Fixed with https://github.com/MineMaarten/PneumaticCraft/commit/c55b7db8e2e91f492e045966f861eb66efcd92f6 , fix on curse shortly

Ampflower commented 8 years ago

I'll see if the fix works soon enough. Those little things needs to be tested for incase.