FIX for #841: NPTR causing crash to desktop due to etching acid missing icon

MineMaarten / PneumaticCraft

PneumaticCraft source

Other

84 stars 50 forks source link

FIX for #841: NPTR causing crash to desktop due to etching acid missing icon #898

Open LachimHeigrim opened 7 years ago

LachimHeigrim commented 7 years ago

Etching acid fluid returned NULL for still and flow icons, causing crash to desktop when acid was placed into Mariculture vat. Additionally the world would not load and repeat crashing as vat was being rendered.

Resolution: Added both still and flow icons based on recolored kerosene icon and registered them properly in BlockFluidEtchingAcid.

ArukaAlter commented 7 years ago

The last activity in the mod was roughly one year ago, this will likely not be merged in the official branch.

LachimHeigrim commented 7 years ago

Has @MineMaarten gave up maintenance of completely? I believe I read on his twitter he does not plan to update to 1.8 and further, but since there are still packs and servers on 1.7.10 in common use, fixing CTDs like this is just common courtesy.