MineSkin / api.mineskin.org

Source of the MineSkin API
https://api.mineskin.org
MIT License
50 stars 5 forks source link

Uploaded skins are replaced with random skins from the global gallery #157

Closed tomas-correia closed 4 years ago

tomas-correia commented 4 years ago

I have tried generating many skins but only one seems to actually be successfully applied to my player. When I try generating the other ones and then try to apply them to my player once I join, it seems to get a random skin from Mineskin's global gallery. First time it happened I logged on with a shrek skin lol. If I go to the gallery and try to download one of my own skins (any of the ones that don't work), it downloads a random skin file from the global gallery. This is extremely annoying and it's driving me insane. Do you have any idea what could be causing this? Again, so far only ONE skin has actually worked. And it's nothing special from the others.

Here's an example. It was supposed to generate according to this skin image But it instead randomly gave me this image

InventivetalentDev commented 4 years ago

It's driving me insane as well, no worries.
Mojang seems to be having some issues at the moment causing theses issues.
I made a couple of changes earlier which might help reduce how often this happens, but no guarantees.

xknat commented 4 years ago

Can confirm. We from SkinsRestorer are now also getting reports. Uploading https://i.imgur.com/UbMwWCF.png Gives http://textures.minecraft.net/texture/33f0306e3488b95a8e29307171b273567de87a651dd1ac6adeb4d6cc67bcf216

tomas-correia commented 4 years ago

Okay. Good to know that at least it's something temporary.

tomas-correia commented 4 years ago

Also @InventivetalentDev could you please let us know when things come back to normal again?

InventivetalentDev commented 4 years ago

will do. hoping this will resolve itself soon myself.

s0nify commented 4 years ago

any news?

InventivetalentDev commented 4 years ago

I'm not sure, to be honest. I wanna say that it's working okayish again, but I guess time will tell.
I've tried with a couple of random textures and some skins from minecraftskins.com and they seem to have generated the correct data.
There might also be the issue of the wrongly generated textures cluttering the database now with the wrong hashes assigned to them, so it might return other textures based on that.

But, I can only test so much, so I'd like to ask you as the users of mineskin to let me know if you run into similar issues again (feel free to post here or on discord). Please also include some info about the image and types generated - if possible, ofc - so I can try and track them down. Thanks!

InventivetalentDev commented 4 years ago

Since this seems related, I'm guessing this is probably also resolved. https://twitter.com/namemc_com/status/1254092487498424320?s=20

tomas-correia commented 4 years ago

Yeah. So far I've only tested one skin (that didn't work earlier) and it works now. Can't confirm if it works with any one, though. So... should I mark this as solved?

InventivetalentDev commented 4 years ago

Let's keep it open for a couple more days and see if it is resolved, then we can close it c:

erickskrauch commented 4 years ago

Hello from the Ely.by!

Our service for generating signed textures has faced the same problem. I investigated and found out that now the request for user's textures has no rate limit (except the general limit of 100rps), but has a cache. And this cache works quite aggressively: it resets its timeout after each access to textures. According to my observations, the caching time is set to 5 minutes, but if you continue to make texture queries, you can get old textures for half an hour, an hour, or even more.

I am also interested in finding solutions to this problem. I'm experimenting a lot with Mojang's APIs, so if you have any ideas to solve this problem, I would be happy to share our experiences.

InventivetalentDev commented 4 years ago

Thanks for the info!
I've tried a couple of times over the last few days and it seems to be working fine again - though I did increase the delay in between requests for individual accounts quite aggressively, so that might've helped.
Fingers crossed this will work out for now.

xknat commented 4 years ago

How are the accounts vs request on peak times? Are there enough accounts?? How long is the average waiting time?

stale[bot] commented 4 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

tomas-correia commented 4 years ago

Nah. At least it hasn't happened again. Thank you all for your collaboration!