search

MineSkin / api.mineskin.org

Source of the MineSkin API
https://api.mineskin.org
MIT License
50 stars 5 forks source link

Incorrect model returns 500 | Format Detection #29

Closed mergu closed 4 years ago

mergu commented 5 years ago

I noticed that specifying the incorrect player model for a provided url fails. I'm not sure if this is an issue with this api or with mojang, but I do know the minecraft launcher allows you to set either model and might distort the skin to fit. Would be great if that functionality was here too, instead of just breaking.

For example,

curl -X POST "https://api.mineskin.org/generate/url?model=slim" -d "url=https://i.imgur.com/Pgu9R1s.png"

will always return

{"error":"Failed to generate skin data","err":"Authentication failed - Invalid credentials. Invalid username or password.","accountId":#}
InventivetalentDev commented 5 years ago

huh, so it works if you use the default model?

mergu commented 5 years ago

Yup it does

ajgeiss0702 commented 5 years ago

Please fix this

InventivetalentDev commented 5 years ago

This isn't really a priority since additionally checking the image data for the skin type is gonna require additional server resources and probably won't be 100% reliable either.
The error message from the original issue is returned by mojang's API (and obviously doesn't give much info), so it'll keep returning 500s for now.

stale[bot] commented 4 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

mergu commented 4 years ago

As far as I can tell, this seems to be fixed. A texture is generated for the correct model regardless of how you call the api.