MineStudio / KMCCC

An OpenSource Minecraft Launcher for .Net Developers
GNU Lesser General Public License v3.0
126 stars 34 forks source link

Added Linux & macOS Support. #12

Open TURX opened 5 years ago

TURX commented 5 years ago

I can now use Mono to launch Minecraft after applying these little modifications. Thank you for reviewing my code!

TURX commented 5 years ago

The CI build failed because I am using NuGet package DotNetZip to deal with zip files.

ZhaiSoul commented 5 years ago

If you wanna get Linux OS Java list, you can use 'whereis java' common. Please reformat your code and make the alignment the same as the original code. Don't change AssemblyName. Have nice day :D

kblackcn commented 5 years ago

The CI build failed because I am using NuGet package DotNetZip to deal with zip files.

I'm the initial developer. There is a reason why this library doesn't support *nix.

We all want to embrace the latest technology such as .net core and the outdated framework is undoubtedly annoying when developing. However, you will find that its framework version is "v4.0". It's the last version that is supported on Windows XP and Supporting Windows XP is actually an important feature. Although Windows XP's market share in China has decreased a lot in recent years, there are still many Windows 7 machines in China that is "optimized", which makes an upgrading .net version very difficult. The reason to avoid NuGet is the objective to produce a single binary. To sum up, nearly everything that outdated is to meet the fundamental realities of the country.