Open FireInstall opened 1 year ago
Until Spark can to what Timings v2 can do the hooks will not be removed from the plugin.
Alright. Just wanted to open a issue for future refference
Do you still stand by your opinion since timings is disabled by default now on paper? Does this mean everyone using Pipes has to re-enable them?
Do you still stand by your opinion since timings is disabled by default now on paper?
Yes
Does this mean everyone using Pipes has to re-enable them?
No, only if you want Pipes-specific Timings.
Also if Paper ends up removing it completely I will look into adapting it to either Spark (if they ever manage to support this way of doing things), the inbuilt Minecraft profiler or even resurrecting my Paper fork Origami to re-add Timings v2.
Well currently there is a PR on Paper to remove timings. I believe it won't get merged this update cycle but if mojang keeps introducing breaking updates in subversions maybe in some 1.21.X...
Used Version
v1.5-SNAPSHOT (build 297)
Environment description
paper 1.20
Log
What is happening?
While it's still working, the timings api is marked for removal and paper is nagging about it. However, I belive while they make a fuss, they do not ship the api themselfs.
Additional context
You may want to have a look into spark docs The Timings API is being used in
io.github.apfelcreme.Pipes.Manager
in lines 108, 241, 273, 320 where it's only ever called in form oftry (Timing t = <Timing>.startTiming()) {...}