search

Minebench / Tresor

An experimental VaultAPI compatible abstraction layer for Bukkit/Spigot/Paper plugins
https://ci.minebench.de/job/Tresor/
GNU General Public License v3.0
8 stars 3 forks source link

placeholder abstraction (#9) #29

Open eyvallahabi opened 1 month ago

eyvallahabi commented 1 month ago

I see your point so i removed the hook method and empty placeholder object this should be better now

Phoenix616 commented 1 month ago

Thanks for adjusting that.

I thought a bit more about this design though and I'm not sure I like the way placeholders are registered. Wouldn't it make more sense to directly register into and query from the providing plugin itself (if it allows for that) and only fall back to a manual map if the plugin does not allow such a thing?

Also as it's designed now one could not register placeholders that take dynamic input via the parameter name. Did you consider that and have a good idea to solve that? Maybe the whole concept of having a Placeholder class doesn't really fit with that seeing as PlaceholderAPI itself doesn't even seem to use that :S

eyvallahabi commented 1 month ago

I'll try to make it better thanks