Minecraft-AMS / Carpet-AMS-Addition

A fabric-carpet extension mod. It offers some interesting and useful features.
https://minecraft-ams.github.io/carpetamsaddition/
GNU Lesser General Public License v3.0
59 stars 7 forks source link

`commandPacketInternetGroper` may have conflicts with `commandPing` #115

Closed wendavid552 closed 3 months ago

wendavid552 commented 4 months ago

Bug description

With Carpet-AMS-Addition installed on 1.18.2 server with carpet-extra, the /ping command from carpet-extra is probably unable to use.

commandPacketInternetGroper可能顶掉了carpet-extra中的命令,导致关掉commandPacketInternetGroper之后/ping也用不了

Steps to reproduce

First activating commandPacketInternetGroper but make commandPacketInternetGroper disabled, it leaves a /ping command. 367dd653624d834d8899989b752a489e_720 While only activating commandPing will cause following problem 4f487c24ea1e5a36ddad2600d177f763

5cc9c781c2b4a5dda9b268783b8d1863

简单来讲,关上commandPacketInternetGroper之后,即使commandPing开了也没用。

Expected behavior

commandPacketInternetGroper commandPing /ping subcommands
true true activated activated
true false deactivated activated
false true activated deactivated

Actual behavior

commandPacketInternetGroper commandPing /ping subcommands
true true activated activated
true false activated activated
false true deactivated deactivated

Relevant logs

No response

Minecraft version

1.18.2 and 1.20.x at least

TemplateMod version

latest

Other information

估计是顶掉对应.require()的问题。disable的时候可能要搞点别的。

Check list

wendavid552 commented 3 months ago

在新版本中更改为/pings前缀以简单规避该问题