search

Minecraft-AMS / Carpet-AMS-Addition

A fabric-carpet extension mod. It offers some interesting and useful features.
https://minecraft-ams.github.io/carpetamsaddition/
GNU Lesser General Public License v3.0
59 stars 7 forks source link

Custom block hardness doesn't work with newer release #79

Closed sternschnaube closed 10 months ago

sternschnaube commented 10 months ago

Bug description

image

image

The version before, without the command enhancement, worked just fine. I hope for a solution 😊

Steps to reproduce

/

Expected behavior

No response

Actual behavior

No response

Relevant logs

No response

Minecraft version

1.20.2

TemplateMod version

Carpet-AMS-Addition v2.22.0

Other information

No response

Check list

1024-byteeeee commented 10 months ago

Sorry, I don't quite understand what you mean. 😅

sternschnaube commented 10 months ago

It just does not work - but all requirements should be set correctly:/

1024-byteeeee commented 10 months ago

它只是不起作用 - 但所有要求都应该正确设置：/

1

The test on my end is successful. 😯

1024-byteeeee commented 10 months ago

它只是不起作用 - 但所有要求都应该正确设置：/

1

The test on my end is successful. 😯

uh~, the translation key has an issue. Let's fix it in the next version, but the functionality is not affected.

sternschnaube commented 10 months ago

Maybe I should check the server log, if there is some mixing error. Thanks for confirming it's functionality. The version without the commands worked too for me.

wendavid552 commented 10 months ago

If you still have the issue, please provide us with your logs and mods list

1024-byteeeee commented 10 months ago

I have identified an issue; currently, this rule only functions correctly on the client side...

sternschnaube commented 10 months ago

Thank you for confirming it, I was about to investigate in about a day again on it. Good that the issue was spotted now 😄

1024-byteeeee commented 10 months ago

谢谢你的确认，我打算在大约一天后再次调查它。很高兴现在发现了😄这个问题

This issue may not be easy to fix.......

sternschnaube commented 10 months ago

If nothing helps - revert back to the version without the commands. It looses a bit from elegance, but at least the effectivity is still present as it was before.

1024-byteeeee commented 10 months ago

If nothing helps - revert back to the version without the commands. It looses a bit from elegance, but at least the effectivity is still present as it was before.

maybe

sternschnaube commented 10 months ago

I think it was "Carpet AMS Addition v2.21.0". Thanks again for all the effort - that's one of the most useful rules of your great mod.

1024-byteeeee commented 10 months ago

我认为是“Carpet AMS Addition v2.21.0”。再次感谢您的所有努力 - 这是您伟大的模组中最有用的规则之一。

No, I killed her. T^T

1024-byteeeee commented 10 months ago

Today I made a painful and difficult decision

Changelog

https://minecraft-ams.github.io/carpetamsaddition/2024/01/04/v2.24.0/

    @1024-byteeeee

sternschnaube commented 10 months ago

For my understanding, the rule is fixed now but other rules had to be removed for that?

But that's all rules anyway who involving in some ways the Block hardness / I see no issue there, it all can be defined with the single rule. Or I am wrong?

1024-byteeeee commented 10 months ago

According to our tests, it seems that modifying block hardness series rules is not suitable to be placed within Carpet. When the server has rules enabled but the client does not have the Carpet AMS addition installed, the performance of players digging blocks becomes quite problematic. We cannot guarantee that all players joining the server have installed the Carpet AMS addition.

This passage is machine-translated, I suggest translating my Chinese.

根据我们的测试来看，修改方块硬度系列规则不适合放在carpet里面，当服务器开启规则客户端却没有安装carpet ams addition时玩家挖掘方块的表现很一言难尽，我们无法保证所有加入服务器的玩家都安装了carpet ams addition。

sternschnaube commented 10 months ago

But it's still present yes? Otherwise I have to downgrade.

It's good to know that players could face block mining problems. If not installed, but that's not the case for me.

1024-byteeeee commented 10 months ago

但它仍然存在，是吗？否则我必须降级。

Past versions will not be deleted, but it is not recommended to install and use them on a multi-user server.

1024-byteeeee commented 10 months ago

In the future, I may turn this rule into a mod dedicated for the client side. ( ? )

sternschnaube commented 10 months ago

Just add a warning message and everything is fine. Why is there never trust and just giving it over to the server owners? Makes no sense to me.

But thanks for all the work you have done 😊

1024-byteeeee commented 10 months ago

Hmm, I cannot guarantee that all users will pay attention to that warning message.

sternschnaube commented 10 months ago

This is not something on you, this is something the server community has to manage.

You are not responsible for that. You gave the mod, the information, that's more than enough.

1024-byteeeee commented 10 months ago

Maybe, It seems reasonable, but I won't consider recalling them at the moment until I find a way that I think is better to implement them.

sternschnaube commented 10 months ago

I think the best solution.

Make it work like the reachDistance rule. It only works if the client has the mod present.

1024-byteeeee commented 10 months ago

I don't know if this can be done because these two things are not the same.

sternschnaube commented 10 months ago

That's true. For me it's not a loss, I downgrade now. And it's working for now until 1.20.4.

Hoping for a better solution.

This rule is more worth than everything else which came with the newer updates - for me.

Adogs1 commented 1 month ago

我不知道这是否可以做到，因为这两件事并不相同。

请问要使用enhancedWorldEater，默认是-1，应该修改到0-16的多少？中文的翻译似乎有点看不懂，谢谢

1024-byteeeee commented 1 month ago

我不知道这是否可以做到，因为这两件事并不相同。

请问要使用enhancedWorldEater，默认是-1，应该修改到0-16的多少？中文的翻译似乎有点看不懂，谢谢

0-16是其他方块的爆炸抗性，建议0-5之间。

Adogs1 commented 1 month ago

我不知道这是否可以做到，因为这两件事并不相同。

请问要使用enhancedWorldEater，默认是-1，应该修改到0-16的多少？中文的翻译似乎有点看不懂，谢谢

0-16是其他方块的爆炸抗性，建议0-5之间。

谢谢