search

Minecraft-Eternal / MC-Eternal-1.12

Tons of thrilling™ Adventures, Magic, Science, Quests, Combat, Bosses, Automation, Exploration, and Rats who shoot cheese from cannons??
48 stars 14 forks source link

[BUG] Agricraft Crop Sticks not spreading to double sticks #509

Open justjamesqq opened 1 year ago

justjamesqq commented 1 year ago

Description of the Bug

Agricraft crop sticks in prior versions used to spread to adjacent double crop sticks and mutate and become a better seed.

This no longer works.

Tested with regular wheat seeds and mystical agriculture seeds.

Expected Behaviour

Crops in the other crop sticks mutate and spread to the double crop sticks

Modpack Version

1.6.1

Screenshots

https://gyazo.com/5283e81ea7fb32052db32b217d7bf9be

Log

No response

Extra Info

I've tested and it works in creative with a creative watering can for some reason but not in survival. I created the new survival save a few days ago on the latest version

justjamesqq commented 1 year ago

Looks like it's an issue here: https://github.com/AgriCraft/AgriCraft/issues/1217 and it's no longer supported so agricraft is basically missing a lot of its functionality.

justjamesqq commented 1 year ago

Fixed it by downgrading back to original version of agricraft

anabsolutesloth commented 1 year ago

This bug report perplexes me, did you make any edits like updating Agricraft manually? it almost sounds as if you did. people in our Discord have had no troubles breeding seeds, so if this is just the spreading, the mod will work fine, Clippers will still let you propagate seeds quickly for spreading around a field.

justjamesqq commented 1 year ago

Breeding was the issue with me. No changes to the settings or the mod.

I tried how I bred back in version 1.3.4 and it worked back then but didn’t work in this pack version which was a 2x2 of crop sticks with one corner a double crop stick.

I then tried a large field with an odd arrangement with some having 4-6 touching fully grown seeds with one double crop stick.

I did all this with a temporal bee nearby which sped up crop growth and a creative watering can that I got from a random reward. Wasn’t able to get anything to breed into a double crop stick. Waited 20+ hours as well just incase it was a timing issue.

After downgrading one version of agricraft it was able to breed.

anabsolutesloth commented 1 year ago

If the issue you linked was related, then downgrading a version should not have helped, unless you had Agricraft 2.12.0-1.12.2-b2, which we do not ship in the full version of MCE, you should have (or had i suppose) 2.12.0-1.12.2-a6.

No changes to the supposedly offending line occurred within the window of Agricraft's 1.12.2 releases, and even an older commit shows something that should be functionally identical being changed, something iffy is going on here i think, or it is just plain infinite misfortune. Infact, that code which they claim is infact for the spreading function, not breeding, so that issue is unrelated to your own it would seem.

Commit history for Crop tileentity: https://github.com/AgriCraft/AgriCraft/commits/1.12.2/src/main/java/com/infinityraider/agricraft/tiles/TileEntityCrop.java

Evidence against supposed "flipped condition" being false (or atleast being less likely to be true): https://github.com/AgriCraft/AgriCraft/commit/e7c4f0e78d174638b9a33d0ab45e280ed9b738c0#diff-ba12cff7c56771122cafa3373d247978d01e29b61eda381b75dc48ef3014b03fL333-R343

Actual breeding function's call: https://github.com/AgriCraft/AgriCraft/blob/d889388abd1f5f192033c0916c009ebabe0f25c9/src/main/java/com/infinityraider/agricraft/tiles/TileEntityCrop.java#L593