search

Minecraft-LightLand / Twilight-Delight

GNU Lesser General Public License v2.1
0 stars 4 forks source link

Neapolitan updated recently and appears to have broken this mod #6

Closed Traehgniw closed 5 months ago

Traehgniw commented 10 months ago

It changed milkshakes to use the flavour's effect and not a custom effect. This mod now crashes the game on startup with an error related to milkshake effects. Going back a version fixes it.

lcy0x1 commented 10 months ago

I thought I have fixed compat issues in 1.4.1. Does it update again?

Traehgniw commented 10 months ago

The 1.19.2 version crashes with Neapolitian's October 6 update

lcy0x1 commented 10 months ago

Make sure you are using twilightdelight-1.4.1, and if you are, send me latest.log

Traehgniw commented 10 months ago

Twilight Delight 1.4.1 does not appear to be released.

lcy0x1 commented 10 months ago

https://legacy.curseforge.com/minecraft/mc-mods/twilights-flavors-delight/files/4802144

Traehgniw commented 10 months ago

Oh it's on Curseforge I was looking on Modrinth

lcy0x1 commented 9 months ago

You can always add blocks to tags through Datapack or KubeJs

drakray commented 5 months ago

There seem to be a crash with the new version for Forge 1.20.1 https://pastebin.com/nZvcnA0i

``` Suppressed: net.minecraftforge.fml.ModLoadingException: Twilight's Flavor & Delight (twilightdelight) encountered an error during the common_setup event phase §7java.lang.NoSuchMethodError: 'void com.teamabnormals.neapolitan.common.item.MilkshakeItem.(net.minecraft.world.effect.MobEffectCategory, net.minecraft.world.item.Item$Properties)' at net.minecraftforge.fml.javafmlmod.FMLModContainer.acceptEvent(FMLModContainer.java:155) ~[language-java-47.2.2.jar%23878!/:47.2] {} at net.minecraftforge.fml.ModLoader.lambda$postEventWithWrapInModOrder$33(ModLoader.java:346) ~[core-47.2.2.jar%23877!/:47.2] {} at java.lang.Iterable.forEach(Iterable.java:75) ~[?:?] {re:mixin} ```
lcy0x1 commented 5 months ago

There seem to be a crash with the new version for Forge 1.20.1 https://pastebin.com/nZvcnA0i

Wow, Neapolitan updated to 1.20.1? I need to work on compat for it to be compatible. I will update it ASAP

lcy0x1 commented 5 months ago

@drakray I can't find Neapolitan for 1.20.1 in CurseForge but I see that in your modlist. Where do you get it?

lcy0x1 commented 5 months ago

Ah, it seems that they are in beta release, so I don't have access to it. Technically gating beta release for money is breaking mojang's EULA but anyway

lcy0x1 commented 5 months ago

Just got the beta and fixed it.