search

Minecraft-Ships / ShipsForCore

The main code to run Ships
https://minecraft-ships.github.io/ShipsForCore/
BSD 2-Clause "Simplified" License
7 stars 6 forks source link

[Bug] Ships Don't Move #104

Closed MrRagtime closed 1 year ago

MrRagtime commented 1 year ago

Describe the bug When I right click on the move sign it don't do anything besides turns the ship to bedrock and back to its og state and doesnt move

To Reproduce

  1. Make a ship

  2. Right click on the wheel sign

  3. Minecraft version (eg. 1.20.1)

  4. Platform Leaves

  5. Ships version Commands do not work but I downloaded the latest release

Log latest (1).log

MrRagtime commented 1 year ago

Video as an Example

https://github.com/Minecraft-Ships/ShipsForCore/assets/134163817/43eb14cf-c3e6-4a17-86ad-c4f5b8539f68

mosemister commented 1 year ago

The turning to bedrock is that its not finding the [ships] sign and that the bedrock is showing you what ships sees as your ship.

There should be a message that tells you this, but isnt showing. I'll look into why the message isnt showing

mosemister commented 1 year ago

Just some notes for myself

Message sent on fail:

https://github.com/Minecraft-Ships/ShipsForCore/blob/bc2ec78c88bb2b4fb1c97e5a1a035008933a19f8/src/main/java/org/ships/vessel/sign/SignUtil.java#L160

Translation of AText:

https://github.com/Minecraft-Ships/CoreToFolia/blob/master/src/main/java/org/core/implementation/folia/entity/living/human/player/live/BLivePlayer.java#L146

MrRagtime commented 1 year ago

Ah alright

MrRagtime commented 1 year ago

Also some bugs I noticed

Version: 6.0.0:Beta-16.0 (Latest Release from Bukkit) + (Latest Release of ShipsBridge)

  1. Right clicking on the [Ships] Ship (Ship name) sign doesn't send the info
  2. When right clicking on the [Wheel] sign or left clicking on the [Move] it can take a long time to do anything (Maybe depending on Ship size?)
  3. All commands do not send/work for /ships
  4. Boats do not move
  5. ShipsBridge-Towny does not load even though I added it to the plugins folder

I saw this as well

Questions

mosemister commented 1 year ago

Thanks for the info

I think all messages for yourself arnt working and likely related to your commands not working too. Mind saying what server your using? Is it pure paper?

Moving a ship take a long time as currently it recalculates your ship every click. This is going to be fixed in the next major release

As for boats, do you mean the vanilla boats? Or one of the ship types?

As for ships Bridge, that was designed for ships 5 sadly and doesnt work on anything Minecraft 1.13+. There will be a alternative for version 6 soonish

MrRagtime commented 1 year ago

np and im using Leaves 102 (1.20,1) https://leavesmc.top/downloads/all I can understand the ship recalculate and I can wait also I meant as for boats do not move as in Ship types (Just added it there as a list of bugs) and ship bridge would've been nice but it cool

mosemister commented 1 year ago

Ive heard of leaves but never used it and therefore i dont officially support it. The issues with commands and messages maybe a result of that as Ships translation layer uses the Adventure library for sending messages which is something that is added on Paper and i know some forks of paper have had issues with it (normally fixed after sending the developers a message)

As for commands, they are one of the few things still registered though the SimpleCommandManager which has officially dropped support, so some forks of paper may have fully dropped it. Next major update should also fix this as the plugin will be registered though the new paper plugin loader.

Interesting that the WaterShip does not move as the logic for moving is shared between all and was tested. Cannot say why that wouldnt work.

Ill have a play with leaves and see if i can replicate it

mosemister commented 1 year ago

Had a play and managed to replicate the issues and have just uploaded a new version of Ships (needs approving).

This isnt a major update so the rescanning every move is still present, but I managed to fix most of what was mentioned here.

also the bar not disappearing when you created a ship type should be fixed too (due to the watership not finishing it register which is why it couldnt move either)

Look out for Beta 16.1

MrRagtime commented 1 year ago

Oh ty! Looking forward to the major update as well

mosemister commented 1 year ago

The patch got approved (not normally that quick)

https://dev.bukkit.org/projects/ships/files/4801390