search

Minecraft-Technocracy / Technocracy

Absolutely excessive tech mod for minecraft
GNU Lesser General Public License v2.1
8 stars 7 forks source link

multiblock stuff #26

Closed deftkHD closed 5 years ago

deftkHD commented 5 years ago

sync for multiblocks hotfix for npes in waila internals (https://github.com/Cydhra/Technocracy/issues/6#issuecomment-514180846)

Cydhra commented 5 years ago

Why does the GUI send a request packet for machine information. The server already knows that the player opened the GUI. Find a way around it, network has to be as optimized as possible

Cydhra commented 5 years ago

About #e78eda7 Minecraft already has a WindowOpen and a WindowClose packet. No need to introduce extra packets.

deftkHD commented 5 years ago

Summary: GUI components are synced for multiblocks and normal machines in an efficient way (Server sends update packets only if the GUI is open and they are required). Also there were some error messages if you looked at tileentities, which belong to multiblock structures, except the controller (first if the multiblock was not completed and after #0340211 if it was completed). These were also fixed with #0562074. #a67ee10 is there just to prevent something bad.