Minecraft-Transit-Railway / Minecraft-Transit-Railway

A Minecraft mod that allows you to build your own transport network with automated trains, boats, cable cars, and planes!
https://www.curseforge.com/minecraft/mc-mods/minecraft-transit-railway
MIT License
362 stars 158 forks source link

Potential client-crashing conflict with Botarium #794

Closed Fureniku closed 4 months ago

Fureniku commented 10 months ago

Expected Behaviour The game to not crash when opening a creative menu while MTR and Botarium are installed

Actual Behaviour When Botarium 1.20.1-2.2.1 is installed alongside MTR 3.2.2-hotfix-2 and Architectury 9.1.12, the game crashes instantly on pressing E to open the inventory in creative mode.

Not tested in survival mode or on other versions. These are the latest versions of all mods.

Reproduction Steps Steps to reproduce the behaviour:

  1. Install the latest MTR, Botarium and Architectury on Forge 1.20.1
  2. Load into a new creative gameworld
  3. Attempt to open your inventory

Crash Report

crash-2024-01-05_00.04.07-client.txt

Screenshots

https://github.com/Minecraft-Transit-Railway/Minecraft-Transit-Railway/assets/856762/9418bab0-3e8c-4952-85b3-ff8db931e898

Environment

Additional Information This was initially reported to Botarium as they're the first-linked mod in the stack, but they are saying it's caused by MTR. Original ticket: https://github.com/terrarium-earth/Botarium/issues/28

kieran-s commented 9 months ago

I had a similar issue running survival (cheats enabled/occasionally swapping to creative), it didn't always crash (sometimes did), but it lagged for a good 20 seconds when opening the inventory. Same errors as in the linked Botarium ticket.

NoaHimesaka1873 commented 6 months ago

If there won't be 4.0 for 1.20.1 (there seems to be some chance), please at least backport fix for this issue.

Yeah, I just ported 4.0.0 to 1.20.1. Problem solved!

Barry23333 commented 5 months ago

~If there won't be 4.0 for 1.20.1 (there seems to be some chance), please at least backport fix for this issue.~

Yeah, I just ported 4.0.0 to 1.20.1. Problem solved!

I found out that 4.0.0 version has only 1.20.4 version. I just want to know is there any way to port it to 1.20.1? Thank you!

Kenny-Hui commented 5 months ago

It has already been ported, just not made it into an official beta release yet. You can use the latest artifacts for 1.20.1.

However I have to mention that MTR 4 is in Beta, and the latest artifacts is even more experimental than the beta builds. Unless MTR is absolutely required for your gameplay, for average users it's recommended to stay on MTR 3 until MTR 4 officially comes out

Barry23333 commented 5 months ago

Gotcha! Thank you so much!

jonafanho commented 4 months ago

This should be fixed in 4.0.0. Please reopen this bug if you still encounter this issue with 4.0.0, thanks!