Request: update `mcfunction` linguist language to use `syntax-mcfunction`

TheAfroOfDoom commented 5 days ago

Summary

A few years ago, @Arcensoth submitted and merged a PR that added language-mcfunction to linguist. This enabled syntax highlighting for .mcfunction files in GitHub! (among other things probably, idk)

https://github.com/github-linguist/linguist/pull/4425

We should update linguist to instead use this repo (syntax-mcfunction) so we get more up-to-date highlighting when we push .mcfunctions.

I don't know the full extent of this, but since Arcensoth has already laid the groundwork I hope it should be relatively straightforward (probably just updating the submodule to point to syntax-mcfunction instead of language-mcfunction).

Basic Example

Some notable current syntax highlighting mishaps include the following cases, as well as whatever other mcfunction language features that have changed since language-mcfunction's last update:

macros show up as a full red line
line continuation doesn't work

Is this specific to a text editor?

Other (please specify above)

Other Info

No response

RitikShah commented 5 days ago

Haha, that's the plan. Tbh, I should have committed for this ages ago but I wanted to get syntax-mcfunction 1:1 to language-mcfunction (it really isn't but it's as close considering the differing architecture).

I want to release a v1.0 so I'm collecting last minute feedback and then I'll make a PR for linguist. This issue will serve as my linguist TODO!

RitikShah commented 5 days ago

Created github-linguist/linguist#6916

MinecraftCommands / syntax-mcfunction