search

MinecraftForge / AccessTransformers

Antlr4 definition for MCP / Forge Access Transformers
GNU Lesser General Public License v2.1
14 stars 12 forks source link

Update FMLAT.md #12

Closed DaemonUmbra closed 4 years ago

DaemonUmbra commented 4 years ago

How about we don't plant the idea of wildcard ATs in people's minds.

LexManos commented 4 years ago

It's technically true, but idiots saying that they can/should do it because the docs is annoying.

DaemonUmbra commented 4 years ago

It's useful to save lines, but it risks the lazy people using it because they just can't be arsed to look up the one field they need.

LexManos commented 4 years ago

Ya I'd be more inclined to say remove the functionality from the spec in some future version. but it would cause nothing but a storm of drama. "saving lines" is not a concern as it should only be a one time thing for one person.

jamierocks commented 4 years ago

Having been removed from the specification, is there any plans to remove the functionality? Or is this just going to be undocumented behaviour now?

LexManos commented 4 years ago

I have to talk to cpw, and others. but as I said I want to. Forge only uses it in 2 places and that is just put of laziness nothing else. Having a wildcard system has zero upsides, and a ton of downsides especially when it is allowed to be used by anyone.

DaemonUmbra commented 4 years ago

I feel like it would be nice for the wildcard to be invalid at runtime but valid for a checkAT task similar to checkSAS. Something that would intercept the wildcard and expand it rather than passing through and users could then pick and choose.

LexManos commented 4 years ago

checkAT is just a forge dev thing in our build script. We could probably expose it as a full task in FG. But yes if we were to do it, then making it a commented line or something so that it could be expanded..